pgsql: Remove duplicate code from ReorderBufferCleanupTXN().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove duplicate code from ReorderBufferCleanupTXN().
Date: 2016-09-05 00:49:51
Message-ID: E1bgi6h-0005qt-4E@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove duplicate code from ReorderBufferCleanupTXN().

Andres is apparently the only hacker who thinks this code is better as-is.
I (tgl) follow some of his logic, but the fact that it's setting off
warnings from static code analyzers seems like a sufficient reason to
put the complexity into a comment rather than the code.

Aleksander Alekseev

Discussion: <20160404190345(dot)54d84ee8(at)fujitsu>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b6182081be4a795d70b966be2542ad32d1ffbc20

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2016-09-05 08:46:00 pgsql: Dirty replication slots when using sql interface
Previous Message Tom Lane 2016-09-05 00:02:37 pgsql: Add regression test coverage for non-default timezone abbreviati