From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix busted Assert for CREATE MATVIEW ... WITH NO DATA. |
Date: | 2016-08-11 15:22:50 |
Message-ID: | E1bXroo-0002qs-Jd@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.
Commit 874fe3aea changed the command tag returned for CREATE MATVIEW/CREATE
TABLE AS ... WITH NO DATA, but missed that there was code in spi.c that
expected the command tag to always be "SELECT". Fortunately, the
consequence was only an Assert failure, so this oversight should have no
impact in production builds.
Since this code path was evidently un-exercised, add a regression test.
Per report from Shivam Saxena. Back-patch to 9.3, like the previous commit.
Michael Paquier
Report: <97218716-480B-4527-B5CD-D08D798A0C7B(at)dresources(dot)com>
Branch
------
REL9_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/942ff002f9ee170d276240c71400e2772458b114
Modified Files
--------------
src/backend/executor/spi.c | 16 ++++++++++++----
src/test/regress/expected/matview.out | 25 +++++++++++++++++++++++++
src/test/regress/sql/matview.sql | 14 ++++++++++++++
3 files changed, 51 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-08-11 16:23:40 | pgsql: Trivial cosmetic cleanup in bloom/blutils.c. |
Previous Message | Tom Lane | 2016-08-11 14:21:02 | pgsql: Doc: fix bad link in 9.1 branch only. |