| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Avoid crashing in GetOldestSnapshot() if there are no known snap |
| Date: | 2016-08-07 18:36:07 |
| Message-ID: | E1bWSvf-0004O9-DA@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Avoid crashing in GetOldestSnapshot() if there are no known snapshots.
The sole caller expects NULL to be returned in such a case, so make
it so and document it.
Per reports from Andreas Seltenreich and Regina Obe. This doesn't
really fix their problem, as now their RETURNING queries will say
"ERROR: no known snapshots", but in any case this function should
not dump core in a reasonably-foreseeable situation.
Report: <87vazemeda(dot)fsf(at)credativ(dot)de>
Report: <20160807051854(dot)1427(dot)32414(at)wrigleys(dot)postgresql(dot)org>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/07a601eedab7c5fa4d62055fa3efacef2f38e446
Modified Files
--------------
src/backend/utils/time/snapmgr.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-07 21:46:13 | pgsql: Fix TOAST access failure in RETURNING queries. |
| Previous Message | Tom Lane | 2016-08-07 17:16:15 | pgsql: Don't propagate a null subtransaction snapshot up to parent tran |