pgsql: Fix assorted problems in recovery tests

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix assorted problems in recovery tests
Date: 2016-08-03 17:26:47
Message-ID: E1bUzwN-0004md-Kh@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix assorted problems in recovery tests

In test 001_stream_rep we're using pg_stat_replication.write_location to
determine catch-up status, but we care about xlog having been applied
not just received, so change that to apply_location.

In test 003_recovery_targets, we query the database for a recovery
target specification and later for the xlog position supposedly
corresponding to that recovery specification. If for whatever reason
more WAL is written between the two queries, the recovery specification
is earlier than the xlog position used by the query in the test harness,
so we wait forever, leading to test failures. Deal with this by using a
single query to extract both items. In 2a0f89cd717 we tried to deal
with it by giving them more tests to run, but in hindsight that was
obviously doomed to failure (no revert of that, though).

Per hamster buildfarm failures.

Author: Michaël Paquier

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b26f7fa6ae2b4e5d64525b3d5bc66a0ddccd9e24

Modified Files
--------------
src/test/recovery/t/001_stream_rep.pl | 4 ++--
src/test/recovery/t/003_recovery_targets.pl | 13 ++++++-------
2 files changed, 8 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-08-03 17:50:56 pgsql: doc: Remove documentation of nonexistent information schema colu
Previous Message Peter Eisentraut 2016-08-03 16:30:40 pgsql: doc: Change recommendation to put NOTIFY into a rule