pgsql: Fix pg_dump's handling of public schema with both -c and -C opti

Fix pg_dump's handling of public schema with both -c and -C options.

Since -c plus -C requests dropping and recreating the target database
as a whole, not dropping individual objects in it, we should assume that
the public schema already exists and need not be created. The previous
coding considered only the state of the -c option, so it would emit
"CREATE SCHEMA public" anyway, leading to an unexpected error in restore.

Back-patch to 9.2. Older versions did not accept -c with -C so the
issue doesn't arise there. (The logic being patched here dates to 8.0,
cf commit 2193121fa, so it's not really wrong that it didn't consider
the case at the time.)

Note that versions before 9.6 will still attempt to emit REVOKE/GRANT
on the public schema; but that happens without -c/-C too, and doesn't
seem to be the focus of this complaint. I considered extending this
stanza to also skip the public schema's ACL, but that would be a
misfeature, as it'd break cases where users intentionally changed that
ACL. The real fix for this aspect is Stephen Frost's work to not dump
built-in ACLs, and that's not going to get back-ported.

Per bugs #13804 and #14271. Solution found by David Johnston and later
rediscovered by me.

Report: <20151207163520(dot)2628(dot)95990(at)wrigleys(dot)postgresql(dot)org>
Report: <20160801021955(dot)1430(dot)47434(at)wrigleys(dot)postgresql(dot)org>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/89c30d1133be5ba4da6098da2ee12114e527f03b

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)