pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Date: 2016-08-01 08:38:51
Message-ID: E1bU8kN-000387-L8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_basebackup so that it accepts 0 as a valid compression level.

The help message for pg_basebackup specifies that the numbers 0 through 9
are accepted as valid values of -Z option. But, previously -Z 0 was rejected
as an invalid compression level.

Per discussion, it's better to make pg_basebackup treat 0 as valid
compression level meaning no compression, like pg_dump.

Back-patch to all supported versions.

Reported-By: Jeff Janes
Reviewed-By: Amit Kapila
Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg(at)mail(dot)gmail(dot)com

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/013f423729a8e7b75bbb80db5212fe320a146343

Modified Files
--------------
doc/src/sgml/ref/pg_basebackup.sgml | 2 +-
src/bin/pg_basebackup/pg_basebackup.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Christoph Berg 2016-08-01 11:04:30 Re: pgsql: doc: mention dependency on collation libraries
Previous Message Tom Lane 2016-07-31 22:33:21 pgsql: Doc: remove claim that hash index creation depends on effective_