pgsql: tqueue.c's record-typmod hashtables need the HASH_BLOBS option.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: tqueue.c's record-typmod hashtables need the HASH_BLOBS option.
Date: 2016-07-28 06:09:01
Message-ID: E1bSeVB-00052K-CV@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

tqueue.c's record-typmod hashtables need the HASH_BLOBS option.

The keys are integers, not strings. The code accidentally worked on
little-endian machines, at least up to 256 distinct record types within
a session, but failed utterly on big-endian. This was unexpectedly
exposed by a test case added by commit 4452000f3, which apparently is the
only parallelizable query in the regression suite that uses more than one
anonymous record type. Fortunately, buildfarm member mandrill is
big-endian and is running with force_parallel_mode on, so it failed.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e1a93dd6ae114669669e3a77167dc3d3bd91e035

Modified Files
--------------
src/backend/executor/tqueue.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2016-07-28 13:36:20 pgsql: Fix incorrect description of udt_privileges view in documentatio
Previous Message Tom Lane 2016-07-27 21:45:13 pgsql: Fix cost_rescan() to account for multi-batch hashing correctly.