pgsql: Fix constant-folding of ROW(...) IS [NOT] NULL with composite fi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix constant-folding of ROW(...) IS [NOT] NULL with composite fi
Date: 2016-07-26 19:25:30
Message-ID: E1bS7ys-0004eL-B5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix constant-folding of ROW(...) IS [NOT] NULL with composite fields.

The SQL standard appears to specify that IS [NOT] NULL's tests of field
nullness are non-recursive, ie, we shouldn't consider that a composite
field with value ROW(NULL,NULL) is null for this purpose.
ExecEvalNullTest got this right, but eval_const_expressions did not,
leading to weird inconsistencies depending on whether the expression
was such that the planner could apply constant folding.

Also, adjust the docs to mention that IS [NOT] DISTINCT FROM NULL can be
used as a substitute test if a simple null check is wanted for a rowtype
argument. That motivated reordering things so that IS [NOT] DISTINCT FROM
is described before IS [NOT] NULL. In HEAD, I went a bit further and added
a table showing all the comparison-related predicates.

Per bug #14235. Back-patch to all supported branches, since it's certainly
undesirable that constant-folding should change the semantics.

Report and patch by Andrew Gierth; assorted wordsmithing and revised
regression test cases by me.

Report: <20160708024746(dot)1410(dot)57282(at)wrigleys(dot)postgresql(dot)org>

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/0733188ccfcef37d715a9b29d5dc987a369a0c86

Modified Files
--------------
doc/src/sgml/func.sgml | 70 +++++++++++++++++-----------------
src/backend/executor/execQual.c | 15 ++++++++
src/backend/optimizer/util/clauses.c | 13 +++++--
src/test/regress/expected/rowtypes.out | 54 ++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql | 24 ++++++++++++
5 files changed, 136 insertions(+), 40 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-07-26 19:39:25 pgsql: Repair damage done by citext--1.1--1.2.sql.
Previous Message Fujii Masao 2016-07-26 12:18:02 pgsql: Fix improper example of using psql() function in TAP tests docum