pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser
Date: 2016-07-26 11:47:50
Message-ID: E1bS0py-0006PM-NJ@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Property 'URL' (of type string) not quoted in browser.js template when extending pgAdmin.Browser. Fixes #1504

Without quotes, the property can be mistakenly treated as a regex:

e.g.: URL: /pgadmin/browser/,

When that happens, JS engine throws "SyntaxError: invalid regular expression flag b" and the whole web interface freezes.
This problem usually occurs when pgadmin is hosted inside a subdirectory (https://host/pgadmin/ instead of https://host/).

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19306934a08f786cba2cd156a14858e66602038c
Author: daze <dazemail(at)mailinator(dot)com>

Modified Files
--------------
web/pgadmin/browser/templates/browser/js/browser.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-07-26 11:55:04 pgAdmin 4 commit: Replace 'Add' buttons with '+'
Previous Message Murtuza Zabuawala 2016-07-26 10:49:11 PATCH: To disable SQLALCHEMY to tracking (pgAdmin4)