pgAdmin 4 commit: Fixes for function, procedure and trigger reverse SQL

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin 4 commit: Fixes for function, procedure and trigger reverse SQL
Date: 2016-07-22 15:38:25
Message-ID: E1bQcWv-0004Id-B3@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fixes for function, procedure and trigger reverse SQL. Fixes #1293. Fixes #1294

1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions

Explanation:
Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for functions, procedure & trigger functions node.
but GRANT statements and COMMENTS changes were missing. In order to fix that, now we have used both 'create.sql' and 'get_definition.sql' templates to generate full SQL query for SQL pane.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=91559c622bdcbecb8ae9b8c53ba572258d7e3c3f
Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>

Modified Files
--------------
.../databases/schemas/functions/__init__.py | 49 ++++++++++++++++++++--
.../templates/function/pg/sql/9.1_plus/create.sql | 27 ++++++++----
.../templates/function/pg/sql/9.2_plus/create.sql | 26 ++++++++----
.../templates/function/pg/sql/9.5_plus/create.sql | 25 +++++++----
.../function/ppas/sql/9.1_plus/create.sql | 27 ++++++++----
.../function/ppas/sql/9.2_plus/create.sql | 26 ++++++++----
.../function/ppas/sql/9.5_plus/create.sql | 3 +-
.../procedure/ppas/sql/9.1_plus/create.sql | 11 ++---
.../procedure/ppas/sql/9.2_plus/create.sql | 10 +++--
.../procedure/ppas/sql/9.5_plus/create.sql | 9 ++--
.../trigger_function/pg/sql/9.1_plus/create.sql | 11 +++--
.../trigger_function/pg/sql/9.2_plus/create.sql | 6 ++-
.../trigger_function/pg/sql/9.5_plus/create.sql | 13 +++---
.../trigger_function/ppas/sql/9.1_plus/create.sql | 11 +++--
.../trigger_function/ppas/sql/9.2_plus/create.sql | 11 +++--
.../trigger_function/ppas/sql/9.5_plus/create.sql | 13 +++---
16 files changed, 201 insertions(+), 77 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-07-22 15:38:36 Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node
Previous Message Dave Page 2016-07-22 15:25:27 pgAdmin 4 commit: Stop using deprecated imports.