pgsql: Provide and use a makefile target to build all generated headers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Provide and use a makefile target to build all generated headers
Date: 2016-07-01 19:09:10
Message-ID: E1bJ3oM-0006cH-Nw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Provide and use a makefile target to build all generated headers.

As of 9.6, pg_regress doesn't build unless storage/lwlocknames.h has been
created; but there was nothing forcing that to happen if you just went into
src/test/regress/ and built there. We previously had a similar complaint
about plpython.

To fix in a way that won't break next time we invent a generated header,
make src/backend/Makefile expose a phony target for updating all the
include files it builds, and invoke that before building pg_regress or
plpython. In principle, maybe we ought to invoke that everywhere; but
it would add a lot of usually-useless make cycles, so let's just do it
in the places where people have complained.

I made a couple of cosmetic adjustments in src/backend/Makefile as well,
to deal with the generated headers in consistent orders.

Michael Paquier and Tom Lane

Report: <31398(dot)1467036827(at)sss(dot)pgh(dot)pa(dot)us>
Report: <20150916200959(dot)GB32090(at)msg(dot)df7cb(dot)de>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/548af97fcec5543603c20b61fec60f8147a05b29

Modified Files
--------------
src/Makefile.global.in | 9 ++++++++-
src/backend/Makefile | 30 ++++++++++++++++++------------
src/pl/plpython/Makefile | 10 +++++-----
src/test/modules/Makefile | 5 +----
src/test/regress/GNUmakefile | 4 ++--
5 files changed, 34 insertions(+), 24 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-07-01 21:32:45 pgsql: Improve WritebackContextInit() comment and prototype argument na
Previous Message Alvaro Herrera 2016-07-01 17:55:20 pgsql: walreceiver: tweak pg_stat_wal_receiver behavior