From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Dodge compiler bug in Visual Studio 2013. |
Date: | 2016-06-29 23:07:24 |
Message-ID: | E1bIOZo-0004XG-HQ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Dodge compiler bug in Visual Studio 2013.
VS2013 apparently has a problem with taking the address of a formal
parameter in some cases. We do that elsewhere without trouble, but
in this case the address is being passed to a subroutine that will
probably get inlined, so maybe the combination of those things is
what tickles the bug. Anyway, introducing an extra copy of the
parameter value is enough to work around it. Per trouble report
from Umair Shahid.
Report: <CAM184AcjqKYZSdQqBHDrnENXHhW=mXbUC46QYPJ=nAh0gUHCGA(at)mail(dot)gmail(dot)com>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/3154e16737ad17b2c63529e3df627bb5eb3bb3be
Modified Files
--------------
src/backend/optimizer/path/costsize.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-06-30 16:37:21 | pgsql: Fix typo in ReorderBufferIterTXNInit(). |
Previous Message | Tom Lane | 2016-06-29 22:51:27 | pgsql: Fix some infelicities in EXPLAIN output for parallel query plans |