pgsql: Revert "Fix "pg_ctl start -w" to test child process status direc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert "Fix "pg_ctl start -w" to test child process status direc
Date: 2016-06-19 18:01:24
Message-ID: E1bEh2C-0003Ce-6f@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Fix "pg_ctl start -w" to test child process status directly."

This reverts commit c869a7d5b44e7164fadfb638786def05d510312a.
As pointed out by Maksym Sobolyev in bug #14199, that approach doesn't
work if the postmaster forks itself an extra time due to silent_mode
being enabled. We removed silent_mode in 9.2, so the pg_ctl change is
fine in 9.2 and later, but it fails when that option is enabled in 9.1.
Seeing that 9.1 is close to end-of-life, let's adopt the most conservative
fix we can, which is to revert the pg_ctl change in the 9.1 branch.

Discussion: <20160618042812(dot)5798(dot)85609(at)wrigleys(dot)postgresql(dot)org>

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d56c02f1ac9247295ec1e5143361020a91f708c8

Modified Files
--------------
src/bin/pg_ctl/pg_ctl.c | 185 ++++++++++++++++++++----------------------------
1 file changed, 78 insertions(+), 107 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andreas Karlsson 2016-06-19 20:28:41 Re: pgsql: Update dblink extension for parallel query.
Previous Message Tom Lane 2016-06-19 17:12:22 pgsql: Docs: improve description of psql's %R prompt escape sequence.