pgsql: Try again to fix the way the scanjoin_target is used with partia

Try again to fix the way the scanjoin_target is used with partial paths.

Commit 04ae11f62e643e07c411c4935ea6af46cb112aa9 removed some broken
code to apply the scan/join target to partial paths, but its theory
that this processing step is totally unnecessary turns out to be wrong.
Put similar code back again, but this time, check for parallel-safety
and avoid in-place modifications to paths that may already have been
used as part of some other path.

(This is not an entirely elegant solution to this problem; it might
be better, for example, to postpone generate_gather_paths for the
topmost scan/join rel until after the scan/join target has been
applied. But this is not the time for such redesign work.)

Amit Kapila and Robert Haas

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/54f5c5150fa05d7ad15f8406debd5a2b394885b5

Modified Files
--------------
src/backend/optimizer/plan/planagg.c | 3 +-
src/backend/optimizer/plan/planner.c | 81 ++++++++++++++++++++++++++-
src/backend/optimizer/prep/prepunion.c | 6 +-
src/backend/optimizer/util/pathnode.c | 7 ++-
src/include/optimizer/pathnode.h | 3 +-
src/test/regress/expected/select_parallel.out | 32 +++++++++++
src/test/regress/sql/select_parallel.sql | 11 ++++
7 files changed, 133 insertions(+), 10 deletions(-)