From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Attempt to fix broken regression test. |
Date: | 2016-06-17 12:40:59 |
Message-ID: | E1bDt51-0001Y3-S3@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Attempt to fix broken regression test.
In commit 8c1d9d56e9a00680a035b8b333a98ea16b121eb7, I attempted to
add a regression test that would fail if the target list was pushed
into a parallel worker, but due to brain fade on my part, it just
randomly fails whether anything bad or not, because the error check
inside the parallel_restricted() function tests whether there is
*any process in the system* that is not connected to a client, not
whether the process running the query is not connected to a client.
A little experimentation has left me pessimistic about the
prospects of doing better here in a short amount of time, so let's
just fall back to checking that the plan is as we expect and leave
the execution-time check for another day.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/103512cee95b5bd0feb83c225eeff61c58874413
Modified Files
--------------
src/test/regress/expected/select_parallel.out | 31 ++-------------------------
src/test/regress/sql/select_parallel.sql | 12 ++---------
2 files changed, 4 insertions(+), 39 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-06-17 12:41:31 | Re: pgsql: Add regression test for 04ae11f62e643e07c411c4935ea6af46cb112aa9 |
Previous Message | Amit Kapila | 2016-06-17 04:55:43 | Re: pgsql: Add regression test for 04ae11f62e643e07c411c4935ea6af46cb112aa9 |