From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Force idle_in_transaction_session_timeout off in pg_dump and aut |
Date: | 2016-06-15 14:53:12 |
Message-ID: | E1bDCBs-0007Em-6K@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Force idle_in_transaction_session_timeout off in pg_dump and autovacuum.
We disable statement_timeout and lock_timeout during dump and restore, to
prevent any global settings that might exist from breaking routine backups.
Commit c6dda1f48 should have added idle_in_transaction_session_timeout to
that list, but failed to.
Another place where these timeouts get turned off is autovacuum. While
I doubt an idle timeout could fire there, it seems better to be safe than
sorry.
pg_dump issue noted by Bernd Helmle, the other one found by grepping.
Report: <352F9B77DB5D3082578D17BB(at)eje(dot)land(dot)credativ(dot)lan>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/8383486f108c650b187358bfe811060627c751c9
Modified Files
--------------
src/backend/postmaster/autovacuum.c | 12 ++++++++----
src/bin/pg_dump/pg_backup_archiver.c | 7 ++++---
src/bin/pg_dump/pg_dump.c | 2 ++
3 files changed, 14 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-06-15 15:45:31 | pgsql: Mark some functions parallel-unsafe. |
Previous Message | Peter Eisentraut | 2016-06-15 14:35:42 | pgsql: PL/Python: Clean up extended error reporting docs and tests |