pgsql: Remove reltarget_has_non_vars flag.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove reltarget_has_non_vars flag.
Date: 2016-06-10 20:20:12
Message-ID: E1bBSua-0004xy-AW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove reltarget_has_non_vars flag.

Commit b12fd41c6 added a "reltarget_has_non_vars" field to RelOptInfo,
but failed to maintain it accurately. Since its only purpose was to skip
calls to has_parallel_hazard() in the simple case where a rel's targetlist
is all Vars, and that call is really pretty cheap in that case anyway, it
seems like this is just a case of premature optimization. Let's drop the
flag and do the calls unconditionally until it's proven that we need more
smarts here.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3303ea1a327b41d3b406d7be7a5ce2901e561066

Modified Files
--------------
src/backend/nodes/outfuncs.c | 1 -
src/backend/optimizer/path/allpaths.c | 9 +++------
src/backend/optimizer/util/placeholder.c | 2 --
src/backend/optimizer/util/relnode.c | 5 +----
src/include/nodes/relation.h | 2 --
5 files changed, 4 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-06-10 22:32:16 pgsql: Change default of backend_flush_after GUC to 0 (disabled).
Previous Message Tom Lane 2016-06-10 20:03:57 pgsql: Refactor to reduce code duplication for function property checki