From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Revert "Use Foreign Key relationships to infer multi-column join |
Date: | 2016-06-07 21:21:31 |
Message-ID: | E1bAORH-00030d-E5@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Revert "Use Foreign Key relationships to infer multi-column join selectivity".
This commit reverts 137805f89 as well as the associated commits 015e88942,
5306df283, and 68d704edb. We found multiple bugs in this feature, and
there was concern about possible planner slowdown (though to be fair,
exhibiting a very large slowdown proved difficult). The way forward
requires a considerable rewrite, which may or may not be possible to
accomplish in time for beta2. In my judgment reviewing the rewrite will
be easier to accomplish starting from a clean slate, so let's temporarily
revert what's there now. This also leaves us in a safe state if it turns
out to be necessary to postpone the rewrite to the next development cycle.
Discussion: <20160429102531(dot)GA13701(at)huehner(dot)biz>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/77ba610805e7ef9ba9c9a593ea8b1ca8f98f8bcb
Modified Files
--------------
src/backend/nodes/outfuncs.c | 13 --
src/backend/optimizer/path/costsize.c | 375 +------------------------------
src/backend/optimizer/util/plancat.c | 85 +------
src/backend/utils/cache/relcache.c | 75 -------
src/backend/utils/misc/guc.c | 9 -
src/include/nodes/nodes.h | 1 -
src/include/nodes/relation.h | 22 --
src/include/optimizer/cost.h | 1 -
src/include/optimizer/paths.h | 2 -
src/include/utils/rel.h | 3 -
src/include/utils/relcache.h | 1 -
src/test/regress/expected/rangefuncs.out | 29 ++-
12 files changed, 25 insertions(+), 591 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2016-06-07 22:00:44 | pgsql: Fix loose ends for SQL ACCESS METHOD objects |
Previous Message | Peter Eisentraut | 2016-06-07 18:19:25 | pgsql: Message style and wording fixes |