pgsql: pg_upgrade: Improve error checking in rewriteVisibilityMap.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_upgrade: Improve error checking in rewriteVisibilityMap.
Date: 2016-06-06 11:45:39
Message-ID: E1b9syR-0004kZ-Tp@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_upgrade: Improve error checking in rewriteVisibilityMap.

In the old logic, if read() were to return an error, we'd silently stop
rewriting the visibility map at that point in the file. That's safe,
but reporting the error is better, so do that instead.

Report by Andres Freund. Patch by Masahiko Sawada, with one correction
by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/aba8943082f1ccbfb19f2e7ff02ba3be0fcb6c9d

Modified Files
--------------
src/bin/pg_upgrade/file.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-06-06 12:00:55 pgsql: Fix typo.
Previous Message Peter Eisentraut 2016-06-05 21:03:07 pgsql: Fix whitespace