pgsql: In Windows pg_dump, ensure idle workers will shut down during er

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In Windows pg_dump, ensure idle workers will shut down during er
Date: 2016-05-26 14:51:00
Message-ID: E1b5wcm-0000ML-80@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In Windows pg_dump, ensure idle workers will shut down during error exit.

The Windows coding of ShutdownWorkersHard() thought that setting termEvent
was sufficient to make workers exit after an error. But that only helps
if a worker is busy and passes through checkAborting(). An idle worker
will just sit, resulting in pg_dump failing to exit until the user gives up
and hits control-C. We should close the write end of the command pipe
so that idle workers will see socket EOF and exit, as the Unix coding was
already doing.

Back-patch to 9.3 where parallel pg_dump was introduced.

Kyotaro Horiguchi

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d32bc204c733276810a400db41f64f32c489733f

Modified Files
--------------
src/bin/pg_dump/parallel.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-05-26 15:51:44 pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ.
Previous Message Alvaro Herrera 2016-05-25 23:40:28 pgsql: Avoid hot standby cancels from VAC FREEZE