| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | pgAdmin 4 commit: Fixed below review comments for QueryTool |
| Date: | 2016-05-06 12:41:17 |
| Message-ID: | E1ayf4H-0002E4-NY@gothos.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Fixed below review comments for QueryTool
- The button bar be moved out into an HTML template
- create.sql should perhaps be renamed to insert.sql
- The "Add Row" button only works if you're on the last page of the resultset.
- Use one wcDocker instead of two
- Added support of code folding
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=894002b06df53d84c735eb8969e98ec4c6b4aba0
Modified Files
--------------
.../tools/datagrid/templates/datagrid/index.html | 114 ++++++++-
web/pgadmin/tools/sqleditor/command.py | 2 +-
.../tools/sqleditor/static/css/sqleditor.css | 39 +++-
.../sqleditor/templates/sqleditor/js/sqleditor.js | 254 ++++++---------------
.../templates/sqleditor/sql/9.1_plus/create.sql | 8 -
.../templates/sqleditor/sql/9.1_plus/insert.sql | 8 +
6 files changed, 219 insertions(+), 206 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-05-06 12:54:04 | pgAdmin 4 commit: First round of string review and cleanup. |
| Previous Message | Akshay Joshi | 2016-05-06 12:25:58 | pgAdmin 4 commit: Added dependency of messages 'pgadmin.browser.message |