From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Fixed below review comments |
Date: | 2016-05-06 12:15:44 |
Message-ID: | E1ayefY-0000pQ-M2@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Fixed below review comments
- Removed the "lineWrapping" option from the codemirror textarea because
it was creating issue in the code folding.
- Handle the values while depositing during debugging.
- Properly handle the Array values while saving it to sqlite database
and displayed in input dialog.
- SQL code folding was not supported in codemirror so added the same.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=149c59aa4fc8a01c9211662f8c16a7cc099f41fc
Author: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Modified Files
--------------
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js | 6 +-
.../codemirror/addon/fold/pgadmin-sqlfoldcode.js | 83 ++++++++++++++++++++++
web/pgadmin/tools/debugger/__init__.py | 76 ++++++++++++--------
web/pgadmin/tools/debugger/static/css/debugger.css | 31 +++++++-
.../debugger/templates/debugger/js/debugger_ui.js | 36 ++++++++--
.../tools/debugger/templates/debugger/js/direct.js | 80 +++++++++++++--------
.../templates/debugger/sql/execute_edbspl.sql | 6 +-
.../templates/debugger/sql/execute_plpgsql.sql | 4 +-
8 files changed, 248 insertions(+), 74 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2016-05-06 12:17:03 | []pgAdmin4[Patch]: Dependencies Tab: Type Icon Issue fix |
Previous Message | Akshay Joshi | 2016-05-06 11:58:56 | Re: New committer: Akshay Joshi |