pgsql: postgres_fdw: Clean up handling of system columns.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: Clean up handling of system columns.
Date: 2016-04-15 16:08:27
Message-ID: E1ar6IF-00022U-Ci@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Clean up handling of system columns.

Previously, querying the xmin column of a single postgres_fdw foreign
table fetched the tuple length, xmax the typmod, and cmin or cmax the
composite type OID of the tuple. However, when you queried several
such tables and the join got shipped to the remote side, these columns
ended up containing the remote values of the corresponding columns.
Both behaviors are rather unprincipled, the former for obvious reasons
and the latter because the remote values of these columns don't have
any local significance; our transaction IDs are in a different space
than those of the remote machine. Clean this up by setting all of
these fields to 0 in both cases. Also fix the handling of tableoid
to be sane.

Robert Haas and Ashutosh Bapat, reviewed by Etsuro Fujita.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/da7d44b627ba839de32c9409aca659f60324de76

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 46 +++++++++++++++++++++++++-
contrib/postgres_fdw/expected/postgres_fdw.out | 42 +++++++++++------------
contrib/postgres_fdw/postgres_fdw.c | 12 +++++++
3 files changed, 78 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-15 16:11:54 pgsql: Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING IND
Previous Message Robert Haas 2016-04-15 15:54:36 pgsql: Tweak EXPLAIN for parallel query to show workers launched.