pgsql: Make regression test for multiple synchronous standbys more stab

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make regression test for multiple synchronous standbys more stab
Date: 2016-04-15 04:59:37
Message-ID: E1aqvqz-0008Dx-Do@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make regression test for multiple synchronous standbys more stable.

The regression test checks whether the output of pg_stat_replication is
expected or not after changing synchronous_standby_names and reloading
the configuration file. Regarding this test logic, previously there was
a timing issue which made the test result unstable. That is,
pg_stat_replication could return unexpected result during small window
after the configuration file was reloaded before new setting value
took effect, and which made the test fail.

This commit changes the test logic so that it uses a loop with a timeout
to give some room for the test to pass. Now the test fails only when
pg_stat_replication keeps returning unexpected result for 30 seconds.

Michael Paquier

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/36c1c91604cee164c6487afb99508f7ff8737b96

Modified Files
--------------
src/test/recovery/t/007_sync_rep.pl | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2016-04-15 05:03:08 Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.
Previous Message Michael Paquier 2016-04-15 04:12:23 Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.