pgsql: pg_dump: add missing "destroyPQExpBuffer(query)" in dumpForeignS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_dump: add missing "destroyPQExpBuffer(query)" in dumpForeignS
Date: 2016-04-11 04:00:15
Message-ID: E1apT1L-0000HC-Mc@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: add missing "destroyPQExpBuffer(query)" in dumpForeignServer().

Coverity complained about this resource leak (why now, I don't know,
since it's been like that a long time). Our general policy in pg_dump
is that PQExpBuffers are worth cleaning up, so do it here too. But
don't bother with a back-patch, because it seems unlikely that very
many databases contain enough FOREIGN SERVER objects to notice.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/074050f16a2db9b5ebe5c9f8fdb211cbb810e746

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-04-11 04:01:01 Re: [COMMITTERS] pgsql: Move each SLRU's lwlocks to a separate tranche.
Previous Message Tom Lane 2016-04-11 03:47:40 pgsql: Clean up foreign-key caching code in planner.