pgsql: Get rid of GenericXLogUnregister().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Get rid of GenericXLogUnregister().
Date: 2016-04-09 20:39:40
Message-ID: E1aozfQ-0004SW-If@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Get rid of GenericXLogUnregister().

This routine is unsafe as implemented, because it invalidates the page
image pointers returned by previous GenericXLogRegister() calls.

Rather than complicate the API or the implementation to avoid that,
let's just get rid of it; the use-case for having it seems much
too thin to justify a lot of work here.

While at it, do some wordsmithing on the SGML docs for generic WAL.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/08e785436f84f8824149a2182b0cb9ce2c28e31d

Modified Files
--------------
doc/src/sgml/generic-wal.sgml | 121 +++++++++++++++++-------------
src/backend/access/transam/generic_xlog.c | 29 -------
src/include/access/generic_xlog.h | 3 +-
3 files changed, 69 insertions(+), 84 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-09 20:44:58 pgsql: Fix PL/Python ereport() test to work on Python 2.3.
Previous Message Tom Lane 2016-04-09 19:39:19 pgsql: Get rid of blinsert()'s use of GenericXLogUnregister().