From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Code review/prettification for generic_xlog.c. |
Date: | 2016-04-09 19:02:39 |
Message-ID: | E1aoy9X-0002xZ-TA@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Code review/prettification for generic_xlog.c.
Improve commentary, use more specific names for the delta fields,
const-ify pointer arguments where possible, avoid assuming that
initializing only the first element of a local array will guarantee
that the remaining elements end up as we need them. (I think that
code in generic_redo actually worked, but only because InvalidBuffer
is zero; this is a particularly ugly way of depending on that ...)
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/db03cf375d602e417eda6b7a55eead91618e1398
Modified Files
--------------
src/backend/access/transam/generic_xlog.c | 159 +++++++++++++++++-------------
1 file changed, 92 insertions(+), 67 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-04-09 19:39:19 | pgsql: Get rid of blinsert()'s use of GenericXLogUnregister(). |
Previous Message | Tom Lane | 2016-04-09 16:46:38 | Re: [COMMITTERS] pgsql: Bloom index contrib module |