pgsql: Code review for error reports in jsonb_set().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for error reports in jsonb_set().
Date: 2016-03-23 15:00:51
Message-ID: E1aikHD-0001Lr-Ju@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review for error reports in jsonb_set().

User-facing (even tested by regression tests) error conditions were thrown
with elog(), hence had wrong SQLSTATE and were untranslatable. And the
error message texts weren't up to project style, either.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ea4b8bd6188ecb17ba37d93f57b8b020a964e66c

Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c | 24 ++++++++++++++----------
src/test/regress/expected/jsonb.out | 12 ++++++------
2 files changed, 20 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-03-23 15:02:08 pgsql: Partition the freelist for shared dynahash tables.
Previous Message Tom Lane 2016-03-23 14:43:33 pgsql: Fix unsafe use of strtol() on a non-null-terminated Text datum.