From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make pgbench's expression lexer reentrant. |
Date: | 2016-03-19 20:35:48 |
Message-ID: | E1ahNbA-0007m6-Bz@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Make pgbench's expression lexer reentrant.
This is a necessary preliminary step for making it play with psqlscan.l
given the way I set up the lexer input-buffer sharing mechanism in commit
0ea9efbe9ec1bf07.
I've not tried to make it *actually* reentrant; there's still some static
variables laying about. But flex thinks it's reentrant, and that's what
counts.
In support of that, fix exprparse.y to pass through the yyscan_t from the
caller. Also do some minor code beautification, like not casting away
const.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/429ee5a822db0e8faf669d77c810f1eeaaff1ab4
Modified Files
--------------
src/bin/pgbench/exprparse.y | 57 ++++++++++++++++++++-----------
src/bin/pgbench/exprscan.l | 83 ++++++++++++++++++++++++++++-----------------
src/bin/pgbench/pgbench.c | 15 +++++---
src/bin/pgbench/pgbench.h | 26 +++++++++-----
4 files changed, 117 insertions(+), 64 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-03-19 20:41:22 | Re: pgsql: pgbench: Silence new compiler warnings |
Previous Message | Fabien COELHO | 2016-03-19 19:46:24 | Re: pgsql: pgbench: Allow changing weights for scripts |