pgsql: Allow callers of create_foreignscan_path to specify nondefault P

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Allow callers of create_foreignscan_path to specify nondefault P
Date: 2016-03-14 21:31:35
Message-ID: E1afa5P-0001Xr-It@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow callers of create_foreignscan_path to specify nondefault PathTarget.

Although the default choice of rel->reltarget should typically be
sufficient for scan or join paths, it's not at all sufficient for the
purposes PathTargets were invented for; in particular not for
upper-relation Paths. So break API compatibility by adding a PathTarget
argument to create_foreignscan_path(). To ease updating of existing
code, accept a NULL value of the argument as selecting rel->reltarget.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/28048cbaa285b8ac46940e4b39f985d9885fc698

Modified Files
--------------
contrib/file_fdw/file_fdw.c | 1 +
contrib/postgres_fdw/postgres_fdw.c | 4 ++++
src/backend/optimizer/util/pathnode.c | 7 +++++--
src/include/optimizer/pathnode.h | 1 +
4 files changed, 11 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-03-14 23:23:36 pgsql: Provide a planner hook at a suitable place for creating upper-re
Previous Message Tom Lane 2016-03-14 21:00:05 pgsql: Rethink representation of PathTargets.