pgsql: Improve conversions from uint64 to Perl types.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve conversions from uint64 to Perl types.
Date: 2016-03-14 18:38:54
Message-ID: E1afXOI-0007Bl-71@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve conversions from uint64 to Perl types.

Perl's integers are pointer-sized, so can hold more than INT_MAX on LP64
platforms, and come in both signed (IV) and unsigned (UV). Floating
point values (NV) may also be larger than double.

Since Perl 5.19.4 array indices are SSize_t instead of I32, so allow up
to SSize_t_max on those versions. The limit is not imposed just by
av_extend's argument type, but all the array handling code, so remove
the speculative comment.

Dagfinn Ilmari Mannsåker

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f3f3aae4b7841f4dc51129691a7404a03eb55449

Modified Files
--------------
src/pl/plperl/plperl.c | 14 +++++---------
src/pl/plperl/plperl.h | 7 +++++++
2 files changed, 12 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-03-14 18:45:51 pgsql: Update PL/Perl's comment about hv_store().
Previous Message Robert Haas 2016-03-14 18:30:23 pgsql: Update more comments for 96198d94cb7adc664bda341842dc8db671d8be7