pgsql: Make GIN regression test stable.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make GIN regression test stable.
Date: 2016-02-08 14:42:23
Message-ID: E1aSn1D-0003X4-Kx@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make GIN regression test stable.

Commit 7f46eaf added the regression test which checks that
gin_clean_pending_list() cleans up the GIN pending list and returns >0.
This usually works fine. But if autovacuum comes along and cleans
the list before gin_clean_pending_list() starts, the function may
return 0, and then the regression test may fail.

To fix the problem, this commit disables autovacuum on the target
index of gin_clean_pending_list() by setting autovacuum_enabled
reloption to off when creating the table.

Also this commit sets gin_pending_list_limit reloption to 4MB on
the target index. Otherwise when running "make installcheck" with
small gin_pending_list_limit GUC, insertions of data may trigger
the cleanup of pending list before gin_clean_pending_list() starts
and the function may return 0. This could cause the regression test
to fail.

Per buildfarm member spoonbill.

Reported-By: Tom Lane

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f8a1c1d5a30003c9c24b00870d5a0f02f1c81e65

Modified Files
--------------
src/test/regress/expected/gin.out | 5 +++--
src/test/regress/sql/gin.sql | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2016-02-08 14:42:56 Re: pgsql: Add gin_clean_pending_list function to clean up GIN pending list
Previous Message Tom Lane 2016-02-08 14:37:38 Re: pgsql: Backpatch of 7a58d19b0 to 9.4, previously omitted.