pgsql: postgres_fdw: Avoid possible misbehavior when RETURNING tableoid

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: Avoid possible misbehavior when RETURNING tableoid
Date: 2016-02-05 03:27:58
Message-ID: E1aRX3u-0000of-B6@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Avoid possible misbehavior when RETURNING tableoid column only.

deparseReturningList ended up adding up RETURNING NULL to the code, but
code elsewhere saw an empty list of attributes and concluded that it
should not expect tuples from the remote side.

Etsuro Fujita and Robert Haas, reviewed by Thom Brown

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2099b911d75738e18749e89019bf75f20dfde4c1

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 18 +++++----
contrib/postgres_fdw/expected/postgres_fdw.out | 53 ++++++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 9 +++++
3 files changed, 73 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-02-05 03:33:02 pgsql: postgres_fdw: pgindent run.
Previous Message Robert Haas 2016-02-05 03:08:15 pgsql: When modifying a foreign table, initialize tableoid field proper