pgsql: postgres_fdw: More preliminary refactoring for upcoming join pus

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: More preliminary refactoring for upcoming join pus
Date: 2016-01-30 15:32:57
Message-ID: E1aPXWD-0003xS-CJ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: More preliminary refactoring for upcoming join pushdown.

The code that generates a complete SQL query for a given foreign relation
was repeated in two places, and they didn't quite agree: the EXPLAIN case
left out the locking clause. Centralize the code so we get the same
behavior everywhere, and adjust calling conventions and which functions
are static vs. extern accordingly . Centralize the code so we get the same
behavior everywhere, and adjust calling conventions and which functions
are static vs. extern accordingly.

Ashutosh Bapat, reviewed and slightly adjusted by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cc592c48c58d9c1920f8e2063756dcbcce79e4dd

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 127 +++++++++++++++++++++---------------
contrib/postgres_fdw/postgres_fdw.c | 38 ++++-------
contrib/postgres_fdw/postgres_fdw.h | 18 +----
3 files changed, 93 insertions(+), 90 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-01-30 20:58:44 pgsql: Fix whitespace
Previous Message Robert Haas 2016-01-29 14:46:45 pgsql: Migrate replication slot I/O locks into a separate tranche.