pgsql: Fix incorrect pattern-match processing in psql's \det command.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix incorrect pattern-match processing in psql's \det command.
Date: 2016-01-29 09:30:16
Message-ID: E1aP5Nh-0000yW-04@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix incorrect pattern-match processing in psql's \det command.

listForeignTables' invocation of processSQLNamePattern did not match up
with the other ones that handle potentially-schema-qualified names; it
failed to make use of pg_table_is_visible() and also passed the name
arguments in the wrong order. Bug seems to have been aboriginal in commit
0d692a0dc9f0e532. It accidentally sort of worked as long as you didn't
inquire too closely into the behavior, although the silliness was later
exposed by inconsistencies in the test queries added by 59efda3e50ca4de6
(which I probably should have questioned at the time, but didn't).

Per bug #13899 from Reece Hart. Patch by Reece Hart and Tom Lane.
Back-patch to all affected branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7e22470471e9ed7010fcbc4a18b0a461d088d7c7

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 10 +++++-----
contrib/postgres_fdw/sql/postgres_fdw.sql | 10 +++++-----
src/bin/psql/describe.c | 3 ++-
3 files changed, 12 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-01-29 09:30:17 pgsql: Fix incorrect pattern-match processing in psql's \det command.
Previous Message Fujii Masao 2016-01-29 03:16:21 pgsql: Fix syntax descriptions for replication commands in logicaldecod