pgsql: Fix brin_summarize_new_values() to check index type and ownershi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix brin_summarize_new_values() to check index type and ownershi
Date: 2015-12-26 17:56:15
Message-ID: E1aCt4h-0005QU-Fk@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix brin_summarize_new_values() to check index type and ownership.

brin_summarize_new_values() did not check that the passed OID was for
an index at all, much less that it was a BRIN index, and would fail in
obscure ways if it wasn't (possibly damaging data first?). It also
lacked any permissions test; by analogy to VACUUM, we should only allow
the table's owner to summarize.

Noted by Jeff Janes, fix by Michael Paquier and me

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e10838026b373f01d1de0f4f7ea80a60c30565da

Modified Files
--------------
src/backend/access/brin/brin.c | 42 +++++++++++++++++++++++++++++++++---
src/test/regress/expected/brin.out | 11 ++++++++++
src/test/regress/sql/brin.sql | 5 +++++
3 files changed, 55 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-12-26 18:41:59 pgsql: Include typmod when complaining about inherited column type mism
Previous Message Fujii Masao 2015-12-25 13:56:49 pgsql: Improve SECURITY LABEL tab completion