pgsql: Simplify LATERAL-related calculations within add_paths_to_joinre

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Simplify LATERAL-related calculations within add_paths_to_joinre
Date: 2015-12-09 23:54:56
Message-ID: E1a6oZU-0001GL-V8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify LATERAL-related calculations within add_paths_to_joinrel().

While convincing myself that commit 7e19db0c09719d79 would solve both of
the problems recently reported by Andreas Seltenreich, I realized that
add_paths_to_joinrel's handling of LATERAL restrictions could be made
noticeably simpler and faster if we were to retain the minimum possible
parameterization for each joinrel (that is, the set of relids supplying
unsatisfied lateral references in it). We already retain that for
baserels, in RelOptInfo.lateral_relids, so we can use that field for
joinrels too.

This is a back-port of commit edca44b1525b3d591263d032dc4fe500ea771e0e.
I originally intended not to back-patch that, but additional hacking
in this area turns out to be needed, making it necessary not optional
to compute lateral_relids for joinrels. In preparation for those fixes,
sync the relevant code with HEAD as much as practical. (I did not risk
rearranging fields of RelOptInfo in released branches, however.)

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7145d35c1727e12cc492c60a2c34392b5ed0dfa5

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 113 ++++++++-------------------------
src/backend/optimizer/util/relnode.c | 2 +-
src/include/nodes/relation.h | 4 +-
3 files changed, 28 insertions(+), 91 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-12-10 15:19:57 pgsql: Accept flex > 2.5.x on Windows, too.
Previous Message Robert Haas 2015-12-09 19:13:14 pgsql: Remove redundant sentence.