pgsql: Avoid odd portability problem in TestLib.pm's slurp_file functio

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid odd portability problem in TestLib.pm's slurp_file functio
Date: 2015-12-08 21:58:28
Message-ID: E1a6QHE-0001wT-Is@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid odd portability problem in TestLib.pm's slurp_file function.

For unclear reasons, this function doesn't always read the expected data
in some old Perl versions. Rewriting it to avoid use of ARGV seems to
dodge the problem, and this version is clearer anyway if you ask me.

In passing, also improve error message in adjacent append_to_file function.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/56a79a5ae9fe1426b07f8ad986777829f19b4437

Modified Files
--------------
src/test/perl/TestLib.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-12-08 22:15:00 pgsql: Make failure to open psql's --log-file fatal.
Previous Message Robert Haas 2015-12-08 19:08:44 pgsql: psql: Support multiple -c and -f options, and allow mixing them.