From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Eschew "RESET statement_timeout" in tests. |
Date: | 2015-10-20 04:40:48 |
Message-ID: | E1ZoOjA-0005OJ-4Q@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Eschew "RESET statement_timeout" in tests.
Instead, use transaction abort. Given an unlucky bout of latency, the
timeout would cancel the RESET itself. Buildfarm members gharial,
lapwing, mereswine, shearwater, and sungazer witness that. Back-patch
to 9.1 (all supported versions). The query_canceled test still could
timeout before entering its subtransaction; for whatever reason, that
has yet to happen on the buildfarm.
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/91d62b14f2a62559338c1b763666fcd25c83c2af
Modified Files
--------------
src/test/regress/expected/plpgsql.out | 43 ++++++++++++++++--------
src/test/regress/expected/prepared_xacts.out | 6 ++--
src/test/regress/expected/prepared_xacts_1.out | 6 ++--
src/test/regress/sql/plpgsql.sql | 37 +++++++++++++-------
src/test/regress/sql/prepared_xacts.sql | 6 ++--
5 files changed, 65 insertions(+), 33 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2015-10-20 05:01:49 | pgsql: Fix back-patch of commit 8e3b4d9d40244c037bbc6e182ea3fabb9347d48 |
Previous Message | Tom Lane | 2015-10-19 20:55:14 | pgsql: Fix incorrect handling of lookahead constraints in pg_regprefix( |