pgsql: Fix pg_dump to handle inherited NOT VALID check constraints corr

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dump to handle inherited NOT VALID check constraints corr
Date: 2015-10-01 20:20:32
Message-ID: E1ZhkLA-0004yd-9Z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_dump to handle inherited NOT VALID check constraints correctly.

This case seems to have been overlooked when unvalidated check constraints
were introduced, in 9.2. The code would attempt to dump such constraints
over again for each child table, even though adding them to the parent
table is sufficient.

In 9.2 and 9.3, also fix contrib/pg_upgrade/Makefile so that the "make
clean" target fully cleans up after a failed test. This evidently got
dealt with at some point in 9.4, but it wasn't back-patched. I ran into
it while testing this fix ...

Per bug #13656 from Ingmar Brouns.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8ab4a6bd3f1a300313eab04d52b0c9a4003f3e43

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 4 ++--
src/test/regress/expected/alter_table.out | 13 +++++++++++++
src/test/regress/sql/alter_table.sql | 4 ++++
3 files changed, 19 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-10-02 01:53:48 pgsql: Fix message punctuation according to style guide
Previous Message Alvaro Herrera 2015-10-01 18:08:00 pgsql: Fix commit_ts for standby