From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix low-probability memory leak in regex execution. |
Date: | 2015-09-18 17:55:44 |
Message-ID: | E1Zczsu-0005N3-MA@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix low-probability memory leak in regex execution.
After an internal failure in shortest() or longest() while pinning down the
exact location of a match, find() forgot to free the DFA structure before
returning. This is pretty unlikely to occur, since we just successfully
ran the "search" variant of the DFA; but it could happen, and it would
result in a session-lifespan memory leak since this code uses malloc()
directly. Problem seems to have been aboriginal in Spencer's library,
so back-patch all the way.
In passing, correct a thinko in a comment I added awhile back about the
meaning of the "ntree" field.
I happened across these issues while comparing our code to Tcl's version
of the library.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d9c0c728afe734b7087dbb9a4bc16d5b682d139d
Modified Files
--------------
src/backend/regex/regcomp.c | 2 +-
src/backend/regex/regexec.c | 6 +++++-
src/include/regex/regguts.h | 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2015-09-18 18:45:55 | pgsql: Cache argument type information in json(b) aggregate functions. |
Previous Message | Tom Lane | 2015-09-18 14:47:19 | Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references. |