pgsql: Attempt to work around a 32bit xlc compiler bug from a different

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Attempt to work around a 32bit xlc compiler bug from a different
Date: 2015-08-07 23:19:36
Message-ID: E1ZNqvI-0003t7-8N@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Attempt to work around a 32bit xlc compiler bug from a different place.

In de6fd1c8 I moved the the work around from 53f73879 into the aix
template. The previous location was removed in the former commit, and I
thought that it would be nice to emit a warning when running configure.

That didn't turn out to work because at the point the template is
included we don't know whether we're compiling a 32/64 bit binary and
it's possible to install compilers for both on a 64 bit kernel/OS.

So go back to a less ambitious approach and define
PG_FORCE_DISABLE_INLINE in port/aix.h, without emitting a warning. We
could try a more fancy approach, but it doesn't seem worth it.

This requires moving the check for PG_FORCE_DISABLE_INLINE in c.h to
after including the system headers included from therein which isn't
perfect, as it seems slightly more robust to include all system headers
in a similar environment. Oh well.

Discussion: 20150807132000(dot)GC13310(at)awork2(dot)anarazel(dot)de

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5a33650f24f9ad67a22c0f8a98c132c75034cfbf

Modified Files
--------------
src/include/c.h | 27 +++++++++++++--------------
src/include/port/aix.h | 9 +++++++++
src/template/aix | 8 --------
3 files changed, 22 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2015-08-08 04:14:34 Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
Previous Message Tom Lane 2015-08-07 18:14:05 pgsql: Further adjustments to PlaceHolderVar removal.