| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Address points made in post-commit review of replication origins |
| Date: | 2015-08-07 13:13:44 |
| Message-ID: | E1ZNhSy-0006zT-30@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Address points made in post-commit review of replication origins.
Amit reviewed the replication origins patch and made some good
points. Address them. This fixes typos in error messages, docs and
comments and adds a missing error check (although in a
should-never-happen scenario).
Discussion: CAA4eK1JqUBVeWWKwUmBPryFaje4190ug0y-OAUHWQ6tD83V4xg(at)mail(dot)gmail(dot)com
Backpatch: 9.5, where replication origins were introduced.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/18e8613564bf0a675d453eec1fceded7bce09988
Modified Files
--------------
doc/src/sgml/catalogs.sgml | 9 +++++----
doc/src/sgml/func.sgml | 2 +-
doc/src/sgml/replication-origins.sgml | 2 +-
src/backend/access/transam/xloginsert.c | 2 +-
src/backend/replication/logical/origin.c | 19 +++++++++++--------
5 files changed, 19 insertions(+), 15 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-08-07 14:08:40 | pgsql: Fix attach-related race condition in shm_mq_send_bytes. |
| Previous Message | Andres Freund | 2015-08-07 13:13:39 | pgsql: Address points made in post-commit review of replication origins |