pgsql: Cap wal_buffers to avoid a server crash when it's set very large

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Cap wal_buffers to avoid a server crash when it's set very large
Date: 2015-08-04 17:11:20
Message-ID: E1ZMfkG-0000bT-Ct@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cap wal_buffers to avoid a server crash when it's set very large.

It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server. Avoid that by imposing a maximum value on
wal_buffers. This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.

Josh Berkus, per an analysis by Andrew Gierth.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/5ef8e1114774ea65eb03f48846e1d708ca8da4be

Modified Files
--------------
src/backend/utils/misc/guc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-08-04 17:13:41 pgsql: Cap wal_buffers to avoid a server crash when it's set very large
Previous Message Robert Haas 2015-08-04 16:30:06 pgsql: Tab completion for CREATE SEQUENCE.