| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Further code review for pg_stat_ssl patch. |
| Date: | 2015-07-27 20:29:48 |
| Message-ID: | E1ZJp1w-0006cp-9F@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Further code review for pg_stat_ssl patch.
Fix additional bogosity in commit 9029f4b37406b21a. Include the
BackendSslStatusBuffer in the BackendStatusShmemSize calculation,
avoid ugly and error-prone casts to char* and back, put related
code stanzas into a consistent order (and fix a couple of previous
instances of that sin). All cosmetic except for the size oversight.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/4c8f8ffaca42bb5678a0858ce56f9a384c21c583
Modified Files
--------------
src/backend/postmaster/pgstat.c | 65 +++++++++++++++++++++++----------------
1 file changed, 38 insertions(+), 27 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-07-27 20:49:23 | pgsql: Improve RLS handling in copy.c |
| Previous Message | Tom Lane | 2015-07-27 19:59:07 | pgsql: Fix pointer-arithmetic thinko in pg_stat_ssl patch. |