pgsql: Don't assume that PageIsEmpty() returns true on an all-zeros pag

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't assume that PageIsEmpty() returns true on an all-zeros pag
Date: 2015-07-27 15:55:42
Message-ID: E1ZJkkg-0002Md-9e@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't assume that PageIsEmpty() returns true on an all-zeros page.

It does currently, and I don't see us changing that any time soon, but we
don't make that assumption anywhere else.

Per Tom Lane's suggestion. Backpatch to 9.2, like the previous patch that
added this assumption.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/0e98ad0915ce5a665f39707db7652c67a64b5b22

Modified Files
--------------
src/backend/access/spgist/spgvacuum.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-27 15:55:45 Re: pgsql: Fix handling of all-zero pages in SP-GiST vacuum.
Previous Message Heikki Linnakangas 2015-07-27 15:37:01 pgsql: Fix memory leak in xlogreader facility.