pgsql: Fix add_rte_to_flat_rtable() for recent feature additions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix add_rte_to_flat_rtable() for recent feature additions.
Date: 2015-07-22 00:04:09
Message-ID: E1ZHhW5-0006J9-5I@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix add_rte_to_flat_rtable() for recent feature additions.

The TABLESAMPLE and row security patches each overlooked this function,
though their errors of omission were opposite: RLS failed to zero out the
securityQuals field, leading to wasteful copying of useless expression
trees in finished plans, while TABLESAMPLE neglected to add a comment
saying that it intentionally *isn't* deleting the tablesample subtree.
There probably should be a similar comment about ctename, too.

Back-patch as appropriate.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/46d0a9bfac3d5221702318cc1cf119221d729c84

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-22 22:31:44 pgsql: Fix off-by-one error in calculating subtrans/multixact truncatio
Previous Message Heikki Linnakangas 2015-07-21 17:59:55 pgsql: Add selectivity estimation functions for intarray operators.