From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix some oversights in BRIN patch. |
Date: | 2015-07-21 17:38:34 |
Message-ID: | E1ZHbUw-0000JR-FQ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix some oversights in BRIN patch.
Remove HeapScanDescData.rs_initblock, which wasn't being used for anything
in the final version of the patch.
Fix IndexBuildHeapScan so that it supports syncscan again; the patch
broke synchronous scanning for index builds by forcing rs_startblk
to zero even when the caller did not care about that and had asked
for syncscan.
Add some commentary and usage defenses to heap_setscanlimits().
Fix heapam so that asking for rs_numblocks == 0 does what you would
reasonably expect. As coded it amounted to requesting a whole-table
scan, because those "--x <= 0" tests on an unsigned variable would
behave surprisingly.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/434873806a9b1c0edd53c2a9df7c93a8ba021147
Modified Files
--------------
src/backend/access/heap/heapam.c | 30 ++++++++++++++++++++----------
src/backend/catalog/index.c | 12 ++++++++++--
src/include/access/relscan.h | 4 ++--
3 files changed, 32 insertions(+), 14 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-07-21 17:59:55 | pgsql: Add selectivity estimation functions for intarray operators. |
Previous Message | Andrew Dunstan | 2015-07-21 13:58:13 | pgsql: Fix location of output logs of pg_regress |