| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix pg_recvlogical not to fsync output when it's a tty or pipe. |
| Date: | 2015-07-07 11:14:57 |
| Message-ID: | E1ZCQq1-0006NX-9i@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix pg_recvlogical not to fsync output when it's a tty or pipe.
The previous coding tried to handle possible failures when fsyncing a
tty or pipe fd by accepting EINVAL - but apparently some
platforms (windows, OSX) don't reliably return that. So instead check
whether the output fd refers to a pipe or a tty when opening it.
Reported-By: Olivier Gosseaume, Marko Tiikkaja
Discussion: 559AF98B(dot)3050901(at)joh(dot)to
Backpatch to 9.4, where pg_recvlogical was added.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/1790b35baf52fff7f670f7cc1159a1b40b36e701
Modified Files
--------------
src/bin/pg_basebackup/pg_recvlogical.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-07-07 11:40:58 | pgsql: Add psql PROMPT variable showing the pid of the connected to bac |
| Previous Message | Andres Freund | 2015-07-07 11:14:55 | pgsql: Fix pg_recvlogical not to fsync output when it's a tty or pipe. |