pgsql: Don't set SO_SNDBUF on recent Windows versions that have a bigge

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't set SO_SNDBUF on recent Windows versions that have a bigge
Date: 2015-07-06 13:14:08
Message-ID: E1ZC6Do-0002Ui-Fm@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't set SO_SNDBUF on recent Windows versions that have a bigger default.

It's unnecessary to set it if the default is higher in the first place.
Furthermore, setting SO_SNDBUF disables the so-called "dynamic send
buffering" feature, which hurts performance further. This can be seen
especially when the network between the client and the server has high
latency.

Chen Huajun

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4f33621f3f50286e607a3cdcc1f7a7d51075af95

Modified Files
--------------
src/backend/libpq/pqcomm.c | 44 ++++++++++++++++++++++++++++++++++++++------
1 file changed, 38 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-06 14:06:15 pgsql: Call getsockopt() on the correct socket.
Previous Message Fujii Masao 2015-07-06 12:00:33 pgsql: Remove incorrect warning from pg_archivecleanup document.